andy/tinyUSB
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

stm32f4: Clarify comments and disable OTGINT; fixes stack reset on

Browse Source 
cable disconnect, and we don't use OTG right now.
This commit is contained in:
William D. Jones
2019-02-14 23:41:16 -05:00
parent 5a34a9de69
commit 5a1c5cf0b7
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/portable/stm/stm32f4/dcd_stm32f4.c
View File

@@ -142,8 +142,10 @@ bool dcd_init (uint8_t rhport)
USB_OTG_GINTSTS_USBRST | USB_OTG_GINTSTS_ENUMDNE | \ USB_OTG_GINTSTS_USBRST | USB_OTG_GINTSTS_ENUMDNE | \
USB_OTG_GINTSTS_ESUSP | USB_OTG_GINTSTS_USBSUSP | USB_OTG_GINTSTS_SOF; USB_OTG_GINTSTS_ESUSP | USB_OTG_GINTSTS_USBSUSP | USB_OTG_GINTSTS_SOF;
// Required as part of core initialization. // Required as part of core initialization. Disable OTGINT as we don't use
USB_OTG_FS->GINTMSK |= USB_OTG_GINTMSK_OTGINT | USB_OTG_GINTMSK_MMISM; // it right now. TODO: How should mode mismatch be handled? It will cause
// the core to stop working/require reset.
USB_OTG_FS->GINTMSK |= /* USB_OTG_GINTMSK_OTGINT | */ USB_OTG_GINTMSK_MMISM;
USB_OTG_DeviceTypeDef * dev = ((USB_OTG_DeviceTypeDef *) (USB_OTG_FS_PERIPH_BASE + USB_OTG_DEVICE_BASE)); USB_OTG_DeviceTypeDef * dev = ((USB_OTG_DeviceTypeDef *) (USB_OTG_FS_PERIPH_BASE + USB_OTG_DEVICE_BASE));
@@ -577,7 +579,7 @@ void OTG_FS_IRQHandler(void) {
_setup_packet[1] = (* rx_fifo); _setup_packet[1] = (* rx_fifo);
} }
break; break;
default: // Invalid, do something here? default: // Invalid, do something here, like breakpoint?
break; break;
} }