andy/tinyUSB
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

Merge pull request #1662 from Erlkoenig90/check-usbd-queue-overflow

Browse Source 
Check for event queue overflow in usbd / dcd_event_handler
This commit is contained in:
Ha Thach
2024-04-16 10:58:15 +07:00
committed by GitHub
parent fcb2df8eb9 189080b684
commit f3781a45d8
4 changed files with 4 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/device/usbd.c
View File

@@ -296,9 +296,9 @@ tu_static osal_queue_t _usbd_q;
#endif #endif
TU_ATTR_ALWAYS_INLINE static inline bool queue_event(dcd_event_t const * event, bool in_isr) { TU_ATTR_ALWAYS_INLINE static inline bool queue_event(dcd_event_t const * event, bool in_isr) {
bool ret = osal_queue_send(_usbd_q, event, in_isr); TU_ASSERT(osal_queue_send(_usbd_q, event, in_isr));
tud_event_hook_cb(event->rhport, event->event_id, in_isr); tud_event_hook_cb(event->rhport, event->event_id, in_isr);
return ret; return true;
} }
//--------------------------------------------------------------------+ //--------------------------------------------------------------------+

4
src/host/usbh.c
View File

@@ -288,9 +288,9 @@ TU_ATTR_WEAK void osal_task_delay(uint32_t msec) {
#endif #endif
TU_ATTR_ALWAYS_INLINE static inline bool queue_event(hcd_event_t const * event, bool in_isr) { TU_ATTR_ALWAYS_INLINE static inline bool queue_event(hcd_event_t const * event, bool in_isr) {
bool ret = osal_queue_send(_usbh_q, event, in_isr); TU_ASSERT(osal_queue_send(_usbh_q, event, in_isr));
tuh_event_hook_cb(event->rhport, event->event_id, in_isr); tuh_event_hook_cb(event->rhport, event->event_id, in_isr);
return ret; return true;
} }
//--------------------------------------------------------------------+ //--------------------------------------------------------------------+

1
src/osal/osal_none.h
View File

@@ -180,7 +180,6 @@ TU_ATTR_ALWAYS_INLINE static inline bool osal_queue_send(osal_queue_t qhdl, void
_osal_q_unlock(qhdl); _osal_q_unlock(qhdl);
} }
TU_ASSERT(success);
return success; return success;
} }

1
src/osal/osal_pico.h
View File

@@ -145,7 +145,6 @@ TU_ATTR_ALWAYS_INLINE static inline bool osal_queue_send(osal_queue_t qhdl, void
bool success = tu_fifo_write(&qhdl->ff, data); bool success = tu_fifo_write(&qhdl->ff, data);
critical_section_exit(&qhdl->critsec); critical_section_exit(&qhdl->critsec);
TU_ASSERT(success);
return success; return success;
} }